geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bschucha...@apache.org
Subject [13/50] [abbrv] incubator-geode git commit: GEODE-469: Don't log a warning if a region is destroyed during creation
Date Thu, 05 Nov 2015 20:35:50 GMT
GEODE-469: Don't log a warning if a region is destroyed during creation

This test saw a suspect string because we logged a warning about a
RegionDestroyedException during region creation. I don't think this
warning should be logged, we don't log warnings for CancelExceptions.


Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/320b6e4b
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/320b6e4b
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/320b6e4b

Branch: refs/heads/feature/GEODE-77
Commit: 320b6e4b6084791358e7f13ebb4ef08b7b0fb9ec
Parents: fa3a47b
Author: Dan Smith <upthewaterspout@apache.org>
Authored: Tue Oct 27 17:30:11 2015 -0700
Committer: Dan Smith <upthewaterspout@apache.org>
Committed: Tue Oct 27 17:34:22 2015 -0700

----------------------------------------------------------------------
 .../java/com/gemstone/gemfire/internal/cache/LocalRegion.java   | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/320b6e4b/gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java
----------------------------------------------------------------------
diff --git a/gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java
b/gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java
index b5e6171..a3b8d35 100644
--- a/gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java
+++ b/gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java
@@ -1086,12 +1086,9 @@ public class LocalRegion extends AbstractRegion
           }
         }
         success = true;
-      } catch (CancelException e) {
+      } catch (CancelException | RegionDestroyedException | RedundancyAlreadyMetException
e) {
         // don't print a call stack
         throw e;
-      } catch(RedundancyAlreadyMetException e) {
-        //don't log this
-        throw e;
       } catch (final RuntimeException validationException) {
         logger.warn(LocalizedMessage.create(LocalizedStrings.LocalRegion_INITIALIZATION_FAILED_FOR_REGION_0,
             getFullPath()), validationException);


Mime
View raw message