geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ash...@apache.org
Subject [33/50] [abbrv] incubator-geode git commit: Adding a TODO to LuceneIndexCreation about the attributes mutator
Date Wed, 11 Nov 2015 21:24:05 GMT
Adding a TODO to LuceneIndexCreation about the attributes mutator

We may need to do something different for replicated regions than what
is being done here in onCreate.


Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/7d50cf15
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/7d50cf15
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/7d50cf15

Branch: refs/heads/develop
Commit: 7d50cf15b2d2bac36a046bb817d45b89bdcd69e7
Parents: 5d7535a
Author: Dan Smith <upthewaterspout@apache.org>
Authored: Thu Oct 15 16:20:54 2015 -0700
Committer: Dan Smith <upthewaterspout@apache.org>
Committed: Fri Oct 16 12:46:55 2015 -0700

----------------------------------------------------------------------
 .../gemfire/cache/lucene/internal/xml/LuceneIndexCreation.java     | 2 ++
 1 file changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/7d50cf15/gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexCreation.java
----------------------------------------------------------------------
diff --git a/gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexCreation.java
b/gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexCreation.java
index 3609ae8..b2f2645 100644
--- a/gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexCreation.java
+++ b/gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexCreation.java
@@ -75,6 +75,8 @@ public class LuceneIndexCreation implements LuceneIndex, Extension<Region<?,
?>>
     String aeqId = LuceneServiceImpl.getUniqueIndexName(getName(), getRegionPath());
     //Here, it is safe to add the aeq with the mutator, because onCreate is
     //fired in a special place before the region is initialized.
+    //TODO - this may only work for PRs. We need to intercept the attributes
+    //before the region is created with a RegionListener.
     region.getAttributesMutator().addAsyncEventQueueId(aeqId);
     service.afterDataRegionCreated(getName(), new StandardAnalyzer(), getRegionPath(), getFieldNames());
   }


Mime
View raw message