geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bschucha...@apache.org
Subject incubator-geode git commit: GEODE-77 disabling use of SynchronousQueueNoSpin
Date Thu, 01 Oct 2015 22:47:11 GMT
Repository: incubator-geode
Updated Branches:
  refs/heads/feature/GEODE-77 592584d61 -> 92a67db37


GEODE-77 disabling use of SynchronousQueueNoSpin

This class has been implicated in the loss of messages during startup.
Its use has been discontinued in GemFire maintenance releases and as
we have seen this problem during testing on feature/GEODE-77 I'm removing
its use from our branch as well.


Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/92a67db3
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/92a67db3
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/92a67db3

Branch: refs/heads/feature/GEODE-77
Commit: 92a67db37045f96e30baf950ca2242e7f2756752
Parents: 592584d
Author: Bruce Schuchardt <bschuchardt@pivotal.io>
Authored: Thu Oct 1 15:46:51 2015 -0700
Committer: Bruce Schuchardt <bschuchardt@pivotal.io>
Committed: Thu Oct 1 15:46:51 2015 -0700

----------------------------------------------------------------------
 .../distributed/internal/PooledExecutorWithDMStats.java | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/92a67db3/gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/PooledExecutorWithDMStats.java
----------------------------------------------------------------------
diff --git a/gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/PooledExecutorWithDMStats.java
b/gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/PooledExecutorWithDMStats.java
index 05f9dd5..f15ac3f 100644
--- a/gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/PooledExecutorWithDMStats.java
+++ b/gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/PooledExecutorWithDMStats.java
@@ -8,19 +8,19 @@
 
 package com.gemstone.gemfire.distributed.internal;
 
-import java.util.concurrent.ThreadPoolExecutor;
+import java.util.List;
+import java.util.concurrent.BlockingQueue;
 import java.util.concurrent.RejectedExecutionException;
 import java.util.concurrent.RejectedExecutionHandler;
-import java.util.concurrent.BlockingQueue;
 import java.util.concurrent.SynchronousQueue;
-import java.util.concurrent.TimeUnit;
 import java.util.concurrent.ThreadFactory;
+import java.util.concurrent.ThreadPoolExecutor;
+import java.util.concurrent.TimeUnit;
+
 import com.gemstone.gemfire.SystemFailure;
 import com.gemstone.gemfire.internal.i18n.LocalizedStrings;
 import com.gemstone.java.util.concurrent.SynchronousQueueNoSpin;
 
-import java.util.List;
-
 /**
  * A ThreadPoolExecutor with stat support.
  * @author darrel
@@ -58,7 +58,7 @@ public class PooledExecutorWithDMStats extends ThreadPoolExecutor {
     if (q instanceof SynchronousQueue || q instanceof SynchronousQueueNoSpin) {
       return q;
     } else {
-      return new SynchronousQueueNoSpin<Runnable>();
+      return new SynchronousQueue/*NoSpin*/<Runnable>();
     }
   }
 


Mime
View raw message