geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kl...@apache.org
Subject [06/30] incubator-geode git commit: GEODE-244: Fixing race in testRecoverRedundancyWithOfflinePersistenceSimulation
Date Mon, 12 Oct 2015 18:43:34 GMT
GEODE-244: Fixing race in testRecoverRedundancyWithOfflinePersistenceSimulation

The test recreates the persistent partitioned region, and then asserts
that all buckets are recovered. But the buckets may be recovered
asynchronously. Now the test will wait for the buckets to show up.


Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/55cd9246
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/55cd9246
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/55cd9246

Branch: refs/heads/feature/GEODE-189-new
Commit: 55cd9246fdcd6b79800caa77651871a127143fb3
Parents: 2810172
Author: Dan Smith <upthewaterspout@apache.org>
Authored: Mon Oct 5 14:38:04 2015 -0700
Committer: Dan Smith <upthewaterspout@apache.org>
Committed: Mon Oct 5 14:38:04 2015 -0700

----------------------------------------------------------------------
 .../internal/cache/control/RebalanceOperationDUnitTest.java     | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/55cd9246/gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/control/RebalanceOperationDUnitTest.java
----------------------------------------------------------------------
diff --git a/gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/control/RebalanceOperationDUnitTest.java
b/gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/control/RebalanceOperationDUnitTest.java
index 1b04ecb..31d889c 100644
--- a/gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/control/RebalanceOperationDUnitTest.java
+++ b/gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/control/RebalanceOperationDUnitTest.java
@@ -2783,8 +2783,11 @@ public class RebalanceOperationDUnitTest extends CacheTestCase {
       /*
        * No rebalancing above because the simulation flag is on.
        * Therefore, vm1 will have recovered its buckets.
+       * We need to wait for the buckets because they
+       * might still be in the middle of creation in the
+       * background
        */
-      assertEquals(vm1Buckets,getBucketList("region1",vm1));      
+      waitForBucketList("region1", vm1, vm1Buckets);      
     }
     
     // look at vm2 buckets


Mime
View raw message