Return-Path: X-Original-To: apmail-geode-commits-archive@minotaur.apache.org Delivered-To: apmail-geode-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A28BD18E2A for ; Wed, 5 Aug 2015 07:34:22 +0000 (UTC) Received: (qmail 93823 invoked by uid 500); 5 Aug 2015 07:34:22 -0000 Delivered-To: apmail-geode-commits-archive@geode.apache.org Received: (qmail 93793 invoked by uid 500); 5 Aug 2015 07:34:22 -0000 Mailing-List: contact commits-help@geode.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.incubator.apache.org Delivered-To: mailing list commits@geode.incubator.apache.org Received: (qmail 93782 invoked by uid 99); 5 Aug 2015 07:34:22 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Aug 2015 07:34:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id C9A6A19B3C2 for ; Wed, 5 Aug 2015 07:34:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.771 X-Spam-Level: * X-Spam-Status: No, score=1.771 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id T8EsuVRnzlzD for ; Wed, 5 Aug 2015 07:34:15 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 5542520775 for ; Wed, 5 Aug 2015 07:34:14 +0000 (UTC) Received: (qmail 93766 invoked by uid 99); 5 Aug 2015 07:34:13 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Aug 2015 07:34:13 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 7A630DFB8D; Wed, 5 Aug 2015 07:34:13 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: kishorbachhav@apache.org To: commits@geode.incubator.apache.org Message-Id: <9612e328af904bdf90071ef69fe66797@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: incubator-geode git commit: GEODE-187:AsyncEventQueue with Event Filter test log shows "IllegalStateException" -AbstractGatewaySenderEventProcessor#processqueue iterates events to get filtered. While iterating 2 consditions are checked and event is remo Date: Wed, 5 Aug 2015 07:34:13 +0000 (UTC) Repository: incubator-geode Updated Branches: refs/heads/develop 8e4c70429 -> 01145b8e9 GEODE-187:AsyncEventQueue with Event Filter test log shows "IllegalStateException" -AbstractGatewaySenderEventProcessor#processqueue iterates events to get filtered. While iterating 2 consditions are checked and event is removed in thses both condition. for single itr.next() when itr.remove is called second time, it causes IllegalStateException. -Added 'continue' after first itr.remove is called Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/01145b8e Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/01145b8e Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/01145b8e Branch: refs/heads/develop Commit: 01145b8e9eeec8d7fdf8e6fed500ff54021ab609 Parents: 8e4c704 Author: kbachhav Authored: Wed Aug 5 12:35:10 2015 +0530 Committer: kbachhav Committed: Wed Aug 5 12:35:10 2015 +0530 ---------------------------------------------------------------------- .../internal/cache/wan/AbstractGatewaySenderEventProcessor.java | 1 + 1 file changed, 1 insertion(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/01145b8e/gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java ---------------------------------------------------------------------- diff --git a/gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java b/gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java index 67b3894..6a0392a 100644 --- a/gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java +++ b/gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java @@ -499,6 +499,7 @@ public abstract class AbstractGatewaySenderEventProcessor extends Thread { itr.remove(); statistics.incEventsNotQueued(); + continue; } boolean transmit = filter.beforeTransmit(event);