geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ash...@apache.org
Subject [1/2] incubator-geode git commit: GEODE-124: Address review comments
Date Mon, 27 Jul 2015 19:17:33 GMT
Repository: incubator-geode
Updated Branches:
  refs/heads/feature/GEODE-124 dad71e90f -> d307eda92


GEODE-124: Address review comments

* Fix spelling mistakes
* Add more details in logs


Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/a0ada760
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/a0ada760
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/a0ada760

Branch: refs/heads/feature/GEODE-124
Commit: a0ada7603d2447c7b70d791a8ae1fa75a4bd413f
Parents: dad71e9
Author: Ashvin Agrawal <ashvin@apache.org>
Authored: Fri Jul 24 14:44:31 2015 -0700
Committer: Ashvin Agrawal <ashvin@apache.org>
Committed: Fri Jul 24 15:10:03 2015 -0700

----------------------------------------------------------------------
 .../gemfire/cache/util/AutoBalancer.java        | 24 +++++++++++---------
 1 file changed, 13 insertions(+), 11 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/a0ada760/gemfire-rebalancer/src/main/java/com/gemstone/gemfire/cache/util/AutoBalancer.java
----------------------------------------------------------------------
diff --git a/gemfire-rebalancer/src/main/java/com/gemstone/gemfire/cache/util/AutoBalancer.java
b/gemfire-rebalancer/src/main/java/com/gemstone/gemfire/cache/util/AutoBalancer.java
index 19c028f..decbd89 100644
--- a/gemfire-rebalancer/src/main/java/com/gemstone/gemfire/cache/util/AutoBalancer.java
+++ b/gemfire-rebalancer/src/main/java/com/gemstone/gemfire/cache/util/AutoBalancer.java
@@ -101,7 +101,7 @@ public class AutoBalancer implements Declarable {
   @Override
   public void init(Properties props) {
     if (logger.isDebugEnabled()) {
-      logger.debug("Initiazing " + this.getClass().getSimpleName() + " with " + props);
+      logger.debug("Initializing " + this.getClass().getSimpleName() + " with " + props);
     }
 
     auditor.init(props);
@@ -140,7 +140,7 @@ public class AutoBalancer implements Declarable {
     @Override
     public void init(String schedule) {
       if (logger.isDebugEnabled()) {
-        logger.debug("Initiazing " + this.getClass().getSimpleName() + " with " + schedule);
+        logger.debug("Initializing " + this.getClass().getSimpleName() + " with " + schedule);
       }
 
       if (schedule == null || schedule.isEmpty()) {
@@ -192,7 +192,7 @@ public class AutoBalancer implements Declarable {
     @Override
     public void init(Properties props) {
       if (logger.isDebugEnabled()) {
-        logger.debug("Initiazing " + this.getClass().getSimpleName());
+        logger.debug("Initializing " + this.getClass().getSimpleName());
       }
 
       if (props != null) {
@@ -303,7 +303,7 @@ public class AutoBalancer implements Declarable {
       try {
         cache.getResourceManager().getStats().incAutoRebalanceAttempts();
       } catch (Exception e) {
-        logger.warn("Failed ot increment AutoBalanceAttempts counter");
+        logger.warn("Failed to increment AutoBalanceAttempts counter");
       }
     }
 
@@ -312,12 +312,14 @@ public class AutoBalancer implements Declarable {
       try {
         RebalanceOperation operation = getCache().getResourceManager().createRebalanceFactory().start();
         RebalanceResults result = operation.getResults();
-        logger.info("Rebalance result: RebalanceResultsImpl [TotalBucketCreateBytes="
-            + result.getTotalBucketCreateBytes() + ", TotalBucketCreatesCompleted="
+        logger.info("Rebalance result: [TotalBucketCreateBytes=" + result.getTotalBucketCreateBytes()
+            + ", TotalBucketCreateTime=" + result.getTotalBucketCreateTime() + ", TotalBucketCreatesCompleted="
             + result.getTotalBucketCreatesCompleted() + ", TotalBucketTransferBytes="
-            + result.getTotalBucketTransferBytes() + ", TotalBucketTransfersCompleted="
-            + result.getTotalBucketTransfersCompleted() + ", TotalPrimaryTransfersCompleted="
-            + result.getTotalPrimaryTransfersCompleted() + "]");
+            + result.getTotalBucketTransferBytes() + ", TotalBucketTransferTime=" + result.getTotalBucketTransferTime()
+            + ", TotalBucketTransfersCompleted=" + +result.getTotalBucketTransfersCompleted()
+            + ", TotalPrimaryTransferTime=" + result.getTotalPrimaryTransferTime()
+            + ", TotalPrimaryTransfersCompleted=" + result.getTotalPrimaryTransfersCompleted()
+ ", TotalTime="
+            + result.getTotalTime() + "]");
       } catch (CancellationException e) {
         logger.info("Error rebalancing the cluster", e);
       } catch (InterruptedException e) {
@@ -338,7 +340,7 @@ public class AutoBalancer implements Declarable {
 
       boolean result = dls.lock(AUTO_BALANCER_LOCK, 0, -1);
       if (logger.isDebugEnabled()) {
-        logger.debug("Grabed AutoBalancer lock? " + result);
+        logger.debug("Grabbed AutoBalancer lock? " + result);
       }
       return result;
     }
@@ -347,7 +349,7 @@ public class AutoBalancer implements Declarable {
       DistributedLockService dls = getDLS();
       dls.unlock(AUTO_BALANCER_LOCK);
       if (logger.isDebugEnabled()) {
-        logger.debug("Successfully release auto-balance ownership");
+        logger.debug("Successfully released auto-balance ownership");
       }
     }
 


Mime
View raw message