Mailing-List: contact dev-help@gearpump.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@gearpump.incubator.apache.org
From: manuzhang <git@git.apache.org>
To: dev@gearpump.incubator.apache.org
Reply-To: dev@gearpump.incubator.apache.org
References: <git-pr-231-incubator-gearpump@git.apache.org>
In-Reply-To: <git-pr-231-incubator-gearpump@git.apache.org>
Subject: [GitHub] incubator-gearpump pull request #231: [GEARPUMP-355] Fix YarnAppMaster addre...
Content-Type: text/plain
Message-Id: <20171019051308.7FBD7DF9F1@git1-us-west.apache.org>
Date: Thu, 19 Oct 2017 05:13:08 +0000 (UTC)
archived-at: Thu, 19 Oct 2017 17:49:25 -0000

Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/231#discussion_r145601399
  
    --- Diff: experiments/yarn/src/main/scala/org/apache/gearpump/experiments/yarn/client/AppMasterResolver.scala ---
    @@ -75,3 +64,38 @@ class AppMasterResolver(yarnClient: YarnClient, system: ActorSystem) {
         result
       }
     }
    +
    +object AppMasterResolver {
    +
    +  val LOG = LogUtil.getLogger(getClass)
    +
    +  def resolveAppMasterAddress(report: ApplicationReport, system: ActorSystem): ActorRef = {
    +    val appMasterPath = s"${report.getOriginalTrackingUrl}" + "supervisor-actor-path"
    +    LOG.info(s"appMasterPath=$appMasterPath")
    +
    +    val connectionFactory: URLConnectionFactory = URLConnectionFactory
    +      .newDefaultURLConnectionFactory(new YarnConfiguration())
    +    val url: URL = new URL(appMasterPath)
    +    val connection: HttpURLConnection = connectionFactory.openConnection(url)
    +      .asInstanceOf[HttpURLConnection]
    +    connection.setInstanceFollowRedirects(true)
    +    connection.connect()
    +    val status = connection.getResponseCode
    +
    +    var stream: java.io.InputStream = connection.getErrorStream
    +    if(stream == null) {
    +      stream = connection.getInputStream
    +    }
    +    if(status == 200) {
    --- End diff --
    
    fix style: need a space before `(`


---