gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEARPUMP-359) The premature OutputWatermark advancing logic in Subscription is not right
Date Thu, 26 Oct 2017 07:19:00 GMT

    [ https://issues.apache.org/jira/browse/GEARPUMP-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220074#comment-16220074
] 

ASF GitHub Bot commented on GEARPUMP-359:
-----------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/234
  
    # [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/234?src=pr&el=h1)
Report
    > Merging [#234](https://codecov.io/gh/apache/incubator-gearpump/pull/234?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-gearpump/commit/8064313afeee1d966ef033a637cfd58d1cca6617?src=pr&el=desc)
will **decrease** coverage by `0.04%`.
    > The diff coverage is `86.66%`.
    
    
    
    ```diff
    @@            Coverage Diff             @@
    ##           master     #234      +/-   ##
    ==========================================
    - Coverage   69.16%   69.12%   -0.05%     
    ==========================================
      Files         191      191              
      Lines        6123     6124       +1     
      Branches      357      362       +5     
    ==========================================
    - Hits         4235     4233       -2     
    - Misses       1888     1891       +3
    ```
    



> The premature OutputWatermark advancing logic in Subscription is not right
> --------------------------------------------------------------------------
>
>                 Key: GEARPUMP-359
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-359
>             Project: Apache Gearpump
>          Issue Type: Bug
>            Reporter: Huafeng Wang
>            Assignee: Huafeng Wang
>
> {{Subscription}} will update processingWatermark when sending a message and update outputWatermark
when receiving an Ack message. It will cause prematurely updating the outputWatermark in such
scenario: the {{Subscription}} already sent 200 messages to downstream and now the processingWatermark
is 200th message's watermark, then it receives the first 100 messages' Ack and it will advance
the outputWatermark to 200th message's watermark, not the 100th one, which is wrong.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message