gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manuzhang <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #234: [GEARPUMP-359] Fix OutputWatermark adv...
Date Thu, 26 Oct 2017 10:45:03 GMT
Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/234#discussion_r147105502
  
    --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/task/Subscription.scala
---
    @@ -209,7 +202,8 @@ class Subscription(
         // to throttle the number of unacked AckRequest
         incrementMessageCount(partition, ackOnceEveryMessageCount)
         val targetTask = TaskId(processorId, partition)
    -    val ackRequest = AckRequest(taskId, messageCount(partition), sessionId)
    +    val processingWaterMark = publisher.getProcessingWatermark.toEpochMilli
    --- End diff --
    
    nitpick: processingWaterMark => processingWatermark


---

Mime
View raw message