gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manuzhang <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #227: [GEARPUMP-350] Fix the not started app...
Date Thu, 26 Oct 2017 00:58:41 GMT
Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/227#discussion_r147024843
  
    --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/task/GroupByTask.scala
---
    @@ -27,15 +27,15 @@ import org.apache.gearpump.cluster.UserConfig
     import org.apache.gearpump.streaming.Constants.{GEARPUMP_STREAMING_GROUPBY_FUNCTION,
GEARPUMP_STREAMING_OPERATOR}
     import org.apache.gearpump.streaming.dsl.window.impl.{TimestampedValue, WindowRunner}
     import org.apache.gearpump.streaming.source.Watermark
    -import org.apache.gearpump.streaming.task.{Task, TaskContext, TaskUtil}
    +import org.apache.gearpump.streaming.task.{Task, TaskContext, TaskUtil, WatermarkProducer}
     
     /**
      * Processes messages in groups as defined by groupBy function.
      */
     class GroupByTask[IN, GROUP, OUT](
         groupBy: IN => GROUP,
         taskContext: TaskContext,
    -    userConfig: UserConfig) extends Task(taskContext, userConfig) {
    +    userConfig: UserConfig) extends Task(taskContext, userConfig) with WatermarkProducer
{
    --- End diff --
    
    Why is `GroupByTask` a `WatermarkProducer` ?


---

Mime
View raw message