gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manuzhang <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #227: [GEARPUMP-350] Fix the not started app...
Date Thu, 26 Oct 2017 00:55:42 GMT
Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/227#discussion_r147024559
  
    --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/task/TaskUtil.scala ---
    @@ -53,6 +53,10 @@ object TaskUtil {
         else t1
       }
     
    +  def min(t1: Instant, t2: Instant, t3: Instant): Instant = {
    --- End diff --
    
    If this is a util, then how about making it more general by accepting *varargs* ?


---

Mime
View raw message