gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manuzhang <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #229: [GEARPUMP-350] Fix the not started app...
Date Wed, 11 Oct 2017 12:08:08 GMT
Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/229#discussion_r143989762
  
    --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/task/Subscription.scala
---
    @@ -61,9 +61,9 @@ class Subscription(
       private val processingWatermarkSince: Array[Short] = new Array[Short](parallelism)
     
       private val outputWatermark: Array[MilliSeconds] = Array.fill(parallelism)(
    -    Watermark.MIN.toEpochMilli)
    +    Watermark.MAX.toEpochMilli)
    --- End diff --
    
    This doesn't look right since the `watermark` method will return maximum value when the
outgoing messages are not acked yet


---

Mime
View raw message