Mailing-List: contact dev-help@gearpump.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@gearpump.incubator.apache.org
From: manuzhang <git@git.apache.org>
To: dev@gearpump.incubator.apache.org
Reply-To: dev@gearpump.incubator.apache.org
References: <git-pr-223-incubator-gearpump@git.apache.org>
In-Reply-To: <git-pr-223-incubator-gearpump@git.apache.org>
Subject: [GitHub] incubator-gearpump pull request #223: [GEARPUMP-349] Optimize Graph topologi...
Content-Type: text/plain
Message-Id: <20170915042522.A949EF5593@git1-us-west.apache.org>
Date: Fri, 15 Sep 2017 04:25:22 +0000 (UTC)
archived-at: Fri, 15 Sep 2017 04:28:12 -0000

Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/223#discussion_r139061587
  
    --- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
    @@ -243,13 +258,36 @@ class Graph[N, E](vertexList: List[N], edgeList: List[(N, E, N)]) extends Serial
        * The node returned by Iterator is stable sorted.
        */
       def topologicalOrderIterator: Iterator[N] = {
    -    val newGraph = copy
    -    var output = List.empty[N]
    +    tryTopologicalOrderIterator match {
    +      case Success(intertor) => intertor
    --- End diff --
    
    intertor ?


---