Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2D860200CF8 for ; Thu, 14 Sep 2017 17:52:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 29DDC1609CD; Thu, 14 Sep 2017 15:52:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 67FC81609CC for ; Thu, 14 Sep 2017 17:52:03 +0200 (CEST) Received: (qmail 74781 invoked by uid 500); 14 Sep 2017 15:52:01 -0000 Mailing-List: contact dev-help@gearpump.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@gearpump.incubator.apache.org Delivered-To: mailing list dev@gearpump.incubator.apache.org Delivered-To: moderator for dev@gearpump.incubator.apache.org Received: (qmail 54370 invoked by uid 99); 14 Sep 2017 12:32:11 -0000 X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.521 X-Spam-Level: X-Spam-Status: No, score=-3.521 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, KAM_LINKBAIT=0.5, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled From: manuzhang To: dev@gearpump.incubator.apache.org Reply-To: dev@gearpump.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-gearpump issue #223: [GEARPUMP-349] Optimize Graph topologicalOrde... Content-Type: text/plain Message-Id: <20170914123208.EFAC6F5647@git1-us-west.apache.org> Date: Thu, 14 Sep 2017 12:32:08 +0000 (UTC) archived-at: Thu, 14 Sep 2017 15:52:04 -0000 Github user manuzhang commented on the issue: https://github.com/apache/incubator-gearpump/pull/223 We also do an extra check for cycle here. Can it be removed ? ```scala if (dag.hasCycle()) { LOG.warn(s"Detected cycles in DAG of application $name!") } val indices = dag.topologicalOrderWithCirclesIterator.toList.zipWithIndex.toMap ``` ---