gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manuzhang <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #227: [GEARPUMP-350] Fix the not started app...
Date Fri, 29 Sep 2017 23:45:22 GMT
Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/227#discussion_r141988691
  
    --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/task/TaskActor.scala
---
    @@ -254,6 +254,7 @@ class TaskActor(
               case m: Message =>
                 count += 1
                 onNext(m)
    +            processingWatermark = TaskUtil.max(processingWatermark, m.timestamp)
    --- End diff --
    
    This doesn't look right for window processing watermark which **can not** advance on every
new message


---

Mime
View raw message