gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manuzhang <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #223: [GEARPUMP-349] Optimize Graph topologi...
Date Fri, 15 Sep 2017 04:23:11 GMT
Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/223#discussion_r139061240
  
    --- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
    @@ -140,64 +155,64 @@ class Graph[N, E](vertexList: List[N], edgeList: List[(N, E, N)])
extends Serial
        * Current Graph is not changed.
        */
       def mapVertex[NewNode](fun: N => NewNode): Graph[NewNode, E] = {
    -    val vertexes = vertices.map(node => (node, fun(node)))
    +    val newVertices = getVertices.map(node => (node, fun(node)))
     
    -    val vertexMap: Map[N, NewNode] = vertexes.toMap
    +    val vertexMap: Map[N, NewNode] = newVertices.toMap
     
    -    val newEdges = edges.map { edge =>
    +    val newEdges = getEdges.map { edge =>
           (vertexMap(edge._1), edge._2, vertexMap(edge._3))
         }
    -    new Graph(vertexes.map(_._2), newEdges)
    +    new Graph(newVertices.map(_._2), newEdges)
       }
     
       /**
        * Map a graph to a new graph, with edge converted to new type
        * Current graph is not changed.
        */
       def mapEdge[NewEdge](fun: (N, E, N) => NewEdge): Graph[N, NewEdge] = {
    -    val newEdges = edges.map { edge =>
    +    val newEdges = getEdges.map { edge =>
           (edge._1, fun(edge._1, edge._2, edge._3), edge._3)
         }
    -    new Graph(vertices, newEdges)
    +    new Graph(getVertices, newEdges)
       }
     
       /**
        * edges connected to node
        */
       def edgesOf(node: N): List[(N, E, N)] = {
    -    (incomingEdgesOf(node) ++ outgoingEdgesOf(node)).toSet[(N, E, N)].toList.sortBy(_indexs(_))
    +    (incomingEdgesOf(node) ++ outgoingEdgesOf(node)).toList
    --- End diff --
    
    no need to sort now ?


---

Mime
View raw message