gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manuzhang <...@git.apache.org>
Subject [GitHub] incubator-gearpump issue #223: [GEARPUMP-349] Optimize Graph topologicalOrde...
Date Thu, 14 Sep 2017 12:32:08 GMT
Github user manuzhang commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/223
  
    We also do an extra check for cycle here. Can it be removed ?
    
    ```scala
        if (dag.hasCycle()) {
          LOG.warn(s"Detected cycles in DAG of application $name!")
        }
    
        val indices = dag.topologicalOrderWithCirclesIterator.toList.zipWithIndex.toMap
    ```


---

Mime
View raw message