Mailing-List: contact dev-help@gearpump.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@gearpump.incubator.apache.org
From: manuzhang <git@git.apache.org>
To: dev@gearpump.incubator.apache.org
Reply-To: dev@gearpump.incubator.apache.org
References: <git-pr-213-incubator-gearpump@git.apache.org>
In-Reply-To: <git-pr-213-incubator-gearpump@git.apache.org>
Subject: [GitHub] incubator-gearpump pull request #213: [GEARPUMP-339] Add ScalaDoc to window ...
Content-Type: text/plain
Message-Id: <20170814020138.B6FA5E93DE@git1-us-west.apache.org>
Date: Mon, 14 Aug 2017 02:01:38 +0000 (UTC)
archived-at: Mon, 14 Aug 2017 02:06:39 -0000

Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/213#discussion_r132863203
  
    --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/impl/WindowRunner.scala ---
    @@ -137,11 +156,14 @@ class DefaultWindowRunner[IN, OUT](
               }
               onTrigger(outputs, newWmk)
             } else {
    -          // minimum of end of last triggered window and start of first un-triggered window
    +          // The output watermark is the minimum of end of last triggered window
    +          // and start of first un-triggered window
               TriggeredOutputs(outputs, TaskUtil.min(wmk, firstWin.startTime))
             }
           } else {
    +        // All windows have been triggered.
             if (time == Watermark.MAX) {
    +          // This means there will no more inputs so it's safe to advance to the maximum watermark.
    --- End diff --
    
    nice catch 😏 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---