Mailing-List: contact dev-help@gearpump.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@gearpump.incubator.apache.org
From: huafengw <git@git.apache.org>
To: dev@gearpump.incubator.apache.org
Reply-To: dev@gearpump.incubator.apache.org
References: <git-pr-212-incubator-gearpump@git.apache.org>
In-Reply-To: <git-pr-212-incubator-gearpump@git.apache.org>
Subject: [GitHub] incubator-gearpump pull request #212: [GEARPUMP-339] Add ScalaDoc to Streami...
Content-Type: text/plain
Message-Id: <20170806150225.A38FEE382D@git1-us-west.apache.org>
Date: Sun,  6 Aug 2017 15:02:25 +0000 (UTC)
archived-at: Mon, 07 Aug 2017 01:04:28 -0000

Github user huafengw commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/212#discussion_r131545040
  
    --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/scalaapi/StreamApp.scala ---
    @@ -62,6 +62,17 @@ class StreamApp(
         val dag = planner.plan(graph)
         StreamApplication(name, dag, userConfig)
       }
    +
    +  def source[T](dataSource: DataSource, parallelism: Int = 1,
    +      conf: UserConfig = UserConfig.empty, description: String = "source"): Stream[T] = {
    +    implicit val sourceOp = DataSourceOp(dataSource, parallelism, description, conf)
    --- End diff --
    
    Has to be implicit?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---