gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes
Date Mon, 14 Aug 2017 01:59:00 GMT

    [ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125128#comment-16125128
] 

ASF GitHub Bot commented on GEARPUMP-339:
-----------------------------------------

Github user huafengw commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/213#discussion_r132863041
  
    --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/impl/WindowRunner.scala
---
    @@ -137,11 +156,14 @@ class DefaultWindowRunner[IN, OUT](
               }
               onTrigger(outputs, newWmk)
             } else {
    -          // minimum of end of last triggered window and start of first un-triggered
window
    +          // The output watermark is the minimum of end of last triggered window
    +          // and start of first un-triggered window
               TriggeredOutputs(outputs, TaskUtil.min(wmk, firstWin.startTime))
             }
           } else {
    +        // All windows have been triggered.
             if (time == Watermark.MAX) {
    +          // This means there will no more inputs so it's safe to advance to the maximum
watermark.
    --- End diff --
    
    there will be no more


> Improve ScalaDoc for all public classes
> ---------------------------------------
>
>                 Key: GEARPUMP-339
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-339
>             Project: Apache Gearpump
>          Issue Type: Improvement
>    Affects Versions: 0.8.4
>            Reporter: Manu Zhang
>            Assignee: Manu Zhang
>
> All public classes should have ScalaDoc and any warnings should be fixed. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message