gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEARPUMP-338) Improve time related types and constants
Date Thu, 03 Aug 2017 13:45:00 GMT


ASF GitHub Bot commented on GEARPUMP-338:

GitHub user manuzhang opened a pull request:

    [GEARPUMP-338] Improve time related types and constants

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the commit message is formatted like:
       `[GEARPUMP-<Jira issue #>] Meaningful description of pull request` 
     - [ ] Make sure tests pass via `sbt clean test`.
     - [ ] Make sure old documentation affected by the pull request has been updated and new
documentation added for new functionality. 

You can merge this pull request into a Git repository by running:

    $ git pull fix_time

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #208
commit 82ee3711be5c84bb08ae530de4be5631cf1819c1
Author: manuzhang <>
Date:   2017-08-03T13:43:03Z

    [GEARPUMP-338] Improve time related types and constants


> Improve time related types and constants
> ----------------------------------------
>                 Key: GEARPUMP-338
>                 URL:
>             Project: Apache Gearpump
>          Issue Type: Improvement
>    Affects Versions: 0.8.4
>            Reporter: Manu Zhang
>            Assignee: Manu Zhang
>             Fix For: 0.8.5
> Currently, there is a type {{TimeStamp}} in package object {{gearpump}}. It's unclear
what the time unit is, seconds or milliseconds. There are also constants {{MAX_TIME_MILLIS}}
and {{MIN_TIME_MILLIS}} for maximum and minimum valid timestamps in milliseconds. All of them
are not easy to find out and import from the package object.
> Propose to move them into a new object singleton {{Time}} and rename type {{TimeStamp}}
to {{MilliSeconds}}

This message was sent by Atlassian JIRA

View raw message