gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEARPUMP-333) Required external dependencies are not assembled in some examples
Date Wed, 02 Aug 2017 03:16:00 GMT

    [ https://issues.apache.org/jira/browse/GEARPUMP-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110200#comment-16110200
] 

ASF GitHub Bot commented on GEARPUMP-333:
-----------------------------------------

GitHub user manuzhang opened a pull request:

    https://github.com/apache/incubator-gearpump/pull/203

    [GEARPUMP-333] Fix examples assembling

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the commit message is formatted like:
       `[GEARPUMP-<Jira issue #>] Meaningful description of pull request` 
     - [ ] Make sure tests pass via `sbt clean test`.
     - [ ] Make sure old documentation affected by the pull request has been updated and new
documentation added for new functionality. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manuzhang/incubator-gearpump fix_example_dep

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-gearpump/pull/203.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #203
    
----
commit 79d1581b43eb5ed1fcb0e808942c5ce12d198f1f
Author: manuzhang <owenzhang1990@gmail.com>
Date:   2017-08-02T03:04:55Z

    [GEARPUMP-333] Fix examples assembling

----


> Required external dependencies are not assembled in some examples
> -----------------------------------------------------------------
>
>                 Key: GEARPUMP-333
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-333
>             Project: Apache Gearpump
>          Issue Type: Bug
>            Reporter: Manu Zhang
>             Fix For: 0.8.5
>
>
> This is a regression brought in by [GEARPUMP-311|https://issues.apache.org/jira/browse/GEARPUMP-331](Allow
examples to be run in IDE), which only assembles the example class itself and breaks all examples
that require external dependencies. 
> It's possible to include those dependencies one by one but a quick solution is to revert
changes to the broken examples and make it clear they can only be run on a gearpump cluster.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message