gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEARPUMP-331) Allow examples to be ran in IDE
Date Thu, 27 Jul 2017 07:45:00 GMT

    [ https://issues.apache.org/jira/browse/GEARPUMP-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102874#comment-16102874
] 

ASF GitHub Bot commented on GEARPUMP-331:
-----------------------------------------

Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/202#discussion_r129773363
  
    --- Diff: docs/contents/dev/dev-write-1st-app.md ---
    @@ -9,7 +9,7 @@ We'll use the classical [wordcount](https://github.com/apache/incubator-gearpump
     	  override val options: Array[(String, CLIOption[Any])] = Array.empty
     	
     	  override def main(akkaConf: Config, args: Array[String]): Unit = {
    -	    val context = ClientContext(akkaConf)
    +	    val context = RuntimeEnvironment.get().newClientContext(akkaConf)
    --- End diff --
    
    Can we hide `RuntimeEnvironment.get()` in `ClientContext` since users don't need to know
? Another benefit is there will be no changes to existing applications.


> Allow examples to be ran in IDE
> -------------------------------
>
>                 Key: GEARPUMP-331
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-331
>             Project: Apache Gearpump
>          Issue Type: Improvement
>            Reporter: Huafeng Wang
>            Assignee: Huafeng Wang
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message