gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEARPUMP-331) Allow examples to be ran in IDE
Date Thu, 27 Jul 2017 07:37:00 GMT

    [ https://issues.apache.org/jira/browse/GEARPUMP-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102858#comment-16102858
] 

ASF GitHub Bot commented on GEARPUMP-331:
-----------------------------------------

Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/202#discussion_r129772131
  
    --- Diff: core/src/main/scala/org/apache/gearpump/cluster/embedded/EmbeddedCluster.scala
---
    @@ -36,27 +36,21 @@ import org.apache.gearpump.util.{LogUtil, Util}
      * Create a in-process cluster with single worker
      */
     class EmbeddedCluster(inputConfig: Config) {
    -
    -  private val workerCount: Int = 1
    -  private var _master: ActorRef = null
    -  private var _system: ActorSystem = null
    -  private var _config: Config = null
    -
       private val LOG = LogUtil.getLogger(getClass)
    +  private val workerCount: Int = 1
    +  var _master: ActorRef = _
    --- End diff --
    
    Do we have to expose these mutable variables ?  BTW, how about removing the prefix "_"
since I don't see any conflicts here ?


> Allow examples to be ran in IDE
> -------------------------------
>
>                 Key: GEARPUMP-331
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-331
>             Project: Apache Gearpump
>          Issue Type: Improvement
>            Reporter: Huafeng Wang
>            Assignee: Huafeng Wang
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message