gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEARPUMP-311) refactor state management
Date Fri, 28 Jul 2017 01:55:00 GMT

    [ https://issues.apache.org/jira/browse/GEARPUMP-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16104308#comment-16104308
] 

ASF GitHub Bot commented on GEARPUMP-311:
-----------------------------------------

Github user manuzhang commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/198
  
    @yanghua Thanks, this is a great effort. I left several comments after a quick glance
through. 
    
    More generally,
    
    1. This is a big PR with new interfaces being introduced. Could we split it into smaller
ones ?
    2. I don't see the `WordCount` examples a strong use case for `State`.  I'm thinking about
questions like "what is the state used for ?", "can it be replaced with a stateless one ?"
    3. I see some existing classes copied under `refactor`. Can you modify the existing codes
directly such that review will easier.


> refactor state management
> -------------------------
>
>                 Key: GEARPUMP-311
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-311
>             Project: Apache Gearpump
>          Issue Type: Improvement
>          Components: streaming
>            Reporter: yanghua
>            Assignee: yanghua
>            Priority: Minor
>
> inspired by Apache Beam



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message