gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manuzhang <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #202: [GEARPUMP-331] Allow applications to b...
Date Thu, 27 Jul 2017 07:44:13 GMT
Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/202#discussion_r129773363
  
    --- Diff: docs/contents/dev/dev-write-1st-app.md ---
    @@ -9,7 +9,7 @@ We'll use the classical [wordcount](https://github.com/apache/incubator-gearpump
     	  override val options: Array[(String, CLIOption[Any])] = Array.empty
     	
     	  override def main(akkaConf: Config, args: Array[String]): Unit = {
    -	    val context = ClientContext(akkaConf)
    +	    val context = RuntimeEnvironment.get().newClientContext(akkaConf)
    --- End diff --
    
    Can we hide `RuntimeEnvironment.get()` in `ClientContext` since users don't need to know
? Another benefit is there will be no changes to existing applications.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message