gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEARPUMP-317) Task minClock could be non increasing
Date Fri, 16 Jun 2017 04:23:00 GMT

    [ https://issues.apache.org/jira/browse/GEARPUMP-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051354#comment-16051354
] 

ASF GitHub Bot commented on GEARPUMP-317:
-----------------------------------------

GitHub user manuzhang opened a pull request:

    https://github.com/apache/incubator-gearpump/pull/187

    [GEARPUMP-317] Fix Task minClock

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the commit message is formatted like:
       `[GEARPUMP-<Jira issue #>] Meaningful description of pull request` 
     - [ ] Make sure tests pass via `sbt clean test`.
     - [ ] Make sure old documentation affected by the pull request has been updated and new
documentation added for new functionality. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manuzhang/incubator-gearpump watermark

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-gearpump/pull/187.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #187
    
----
commit 91711240364601b159353a441afb476acaa3abed
Author: manuzhang <owenzhang1990@gmail.com>
Date:   2017-06-14T13:35:06Z

    [GEARPUMP-317] Fix Task minClock

----


> Task minClock could be non increasing
> -------------------------------------
>
>                 Key: GEARPUMP-317
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-317
>             Project: Apache Gearpump
>          Issue Type: Bug
>          Components: streaming
>    Affects Versions: 0.8.3
>            Reporter: Manu Zhang
>            Assignee: Manu Zhang
>
> Task minClock is the minimum of upstream minClock and output minClock. Considering the
following scenario,
> 1. Output minClock is set to Long.MaxValue since all messages have been acked by downstream
tasks
> 2. But there are messages buffered in a window function
> 3. Later the window is triggered and those messages are emitted, which will set the output
minClock to a smaller value.
> 4. Plus, the output messages are possibly not in time order, which again will make output
minClock non increasing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message