gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From huafengw <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #187: [GEARPUMP-317] Fix Task minClock
Date Sun, 18 Jun 2017 11:05:00 GMT
Github user huafengw commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/187#discussion_r122588208
  
    --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/task/GroupByTask.scala
---
    @@ -61,13 +62,14 @@ class GroupByTask[IN, GROUP, OUT](
       }
     
       override def onWatermarkProgress(watermark: Instant): Unit = {
    -    groups.values.forEach(new Consumer[WindowRunner[IN, OUT]] {
    -      override def accept(runner: WindowRunner[IN, OUT]): Unit = {
    -        runner.trigger(watermark).foreach {
    -          result =>
    -            taskContext.output(Message(result.value, result.timestamp))
    +    if (groups.isEmpty && watermark == Watermark.MAX) {
    --- End diff --
    
    Why we have a special case here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message