Mailing-List: contact dev-help@gearpump.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@gearpump.incubator.apache.org
Date: Mon, 8 May 2017 01:45:04 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@gearpump.incubator.apache.org
Message-ID: <JIRA.13069366.1493971558000.147831.1494207904120@Atlassian.JIRA>
In-Reply-To: <JIRA.13069366.1493971558000@Atlassian.JIRA>
References: <JIRA.13069366.1493971558000@Atlassian.JIRA> <JIRA.13069366.1493971558707@jira-lw-us.apache.org>
Subject: [jira] [Commented] (GEARPUMP-303) add a RabbitMQ sink to integrate
 with gearpump
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 08 May 2017 01:45:09 -0000


    [ https://issues.apache.org/jira/browse/GEARPUMP-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000169#comment-16000169 ] 

ASF GitHub Bot commented on GEARPUMP-303:
-----------------------------------------

Github user huafengw commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/180#discussion_r115162272
  
    --- Diff: experiments/rabbitmq/src/test/scala/org/apache/gearpump/experimental/rabbitmq/RabbitmqSinkSpec.scala ---
    @@ -0,0 +1,53 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *      http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.gearpump.experimental.rabbitmq
    +
    +import com.rabbitmq.client.AMQP.Connection
    +import com.rabbitmq.client.ConnectionFactory
    +import org.apache.gearpump.Message
    --- End diff --
    
    And it would be better if there is no unused import.


> add a RabbitMQ sink to integrate with gearpump
> ----------------------------------------------
>
>                 Key: GEARPUMP-303
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-303
>             Project: Apache Gearpump
>          Issue Type: Task
>          Components: connectors
>            Reporter: yanghua
>            Assignee: yanghua
>


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)