gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEARPUMP-312) Allow Message to be extensible
Date Thu, 18 May 2017 04:55:04 GMT

    [ https://issues.apache.org/jira/browse/GEARPUMP-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015202#comment-16015202
] 

ASF GitHub Bot commented on GEARPUMP-312:
-----------------------------------------

Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/183#discussion_r117160807
  
    --- Diff: integrationtest/core/src/it/scala/org/apache/gearpump/integrationtest/checklist/DefaultMessageDeliverySpec.scala
---
    @@ -28,7 +28,7 @@ import org.apache.gearpump.integrationtest.{TestSpecBase, Util}
     /**
      * Checks message delivery consistency, like at-least-once, and exactly-once.
      */
    -class MessageDeliverySpec extends TestSpecBase {
    +class DefaultMessageDeliverySpec extends TestSpecBase {
    --- End diff --
    
    oh, my IDE is to blame for this.


> Allow Message to be extensible
> ------------------------------
>
>                 Key: GEARPUMP-312
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-312
>             Project: Apache Gearpump
>          Issue Type: Improvement
>    Affects Versions: 0.8.3
>            Reporter: Manu Zhang
>            Assignee: Manu Zhang
>
> The current {{case class Message(msg: Any, timeInMillis: TimeStamp)}} is not extensible
with an additional timestamp field while users' message may already carry that information.
 I don't think we care about what is stored in the message but what we can get from it. 
> I propose to add a new interface {{Message}} with {{value}} and {{timestamp}} fields/methods
and rename the current {{Message}} to {{DefaultMessage}} as a default implementation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message