gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEARPUMP-312) Allow Message to be extensible
Date Wed, 17 May 2017 07:07:04 GMT

    [ https://issues.apache.org/jira/browse/GEARPUMP-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16013649#comment-16013649
] 

ASF GitHub Bot commented on GEARPUMP-312:
-----------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/183
  
    # [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/183?src=pr&el=h1)
Report
    > Merging [#183](https://codecov.io/gh/apache/incubator-gearpump/pull/183?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-gearpump/commit/000e846ab227a2113a182b5d6917724f128cb63a?src=pr&el=desc)
will **increase** coverage by `0.04%`.
    > The diff coverage is `79.41%`.
    
    
    
    ```diff
    @@            Coverage Diff             @@
    ##           master     #183      +/-   ##
    ==========================================
    + Coverage    71.6%   71.64%   +0.04%     
    ==========================================
      Files         191      191              
      Lines        6082     6084       +2     
      Branches      524      521       -3     
    ==========================================
    + Hits         4355     4359       +4     
    + Misses       1727     1725       -2
    ```
    



> Allow Message to be extensible
> ------------------------------
>
>                 Key: GEARPUMP-312
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-312
>             Project: Apache Gearpump
>          Issue Type: Improvement
>    Affects Versions: 0.8.3
>            Reporter: Manu Zhang
>            Assignee: Manu Zhang
>
> The current {{case class Message(msg: Any, timeInMillis: TimeStamp)}} is not extensible
with an additional timestamp field while users' message may already carry that information.
 I don't think we care about what is stored in the message but what we can get from it. 
> I propose to add a new interface {{Message}} with {{value}} and {{timestamp}} fields/methods
and rename the current {{Message}} to {{DefaultMessage}} as a default implementation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message