gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEARPUMP-295) Get stalling tasks from clock service failed
Date Thu, 20 Apr 2017 03:16:04 GMT

    [ https://issues.apache.org/jira/browse/GEARPUMP-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975980#comment-15975980
] 

ASF GitHub Bot commented on GEARPUMP-295:
-----------------------------------------

Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/174#discussion_r112357813
  
    --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/appmaster/ClockService.scala
---
    @@ -261,7 +261,8 @@ class ClockService(
         case GetCheckpointClock =>
           sender ! CheckpointClock(minCheckpointClock)
     
    -    case GetStallingTasks =>
    +    // Please do not remove the `getStalling`
    +    case getStalling: GetStallingTasks =>
    --- End diff --
    
    If the field of `GetStallingTasks` is never used, we'd better turn it into a case object


> Get stalling tasks from clock service failed
> --------------------------------------------
>
>                 Key: GEARPUMP-295
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-295
>             Project: Apache Gearpump
>          Issue Type: Bug
>            Reporter: Huafeng Wang
>            Assignee: Huafeng Wang
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message