Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0B483200C16 for ; Thu, 9 Feb 2017 11:54:54 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 09F73160B50; Thu, 9 Feb 2017 10:54:54 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 54371160B4C for ; Thu, 9 Feb 2017 11:54:53 +0100 (CET) Received: (qmail 59728 invoked by uid 500); 9 Feb 2017 10:54:52 -0000 Mailing-List: contact dev-help@gearpump.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@gearpump.incubator.apache.org Delivered-To: mailing list dev@gearpump.incubator.apache.org Received: (qmail 59713 invoked by uid 99); 9 Feb 2017 10:54:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Feb 2017 10:54:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 2FCA0180684 for ; Thu, 9 Feb 2017 10:54:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.198 X-Spam-Level: X-Spam-Status: No, score=-1.198 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id ojcLkX2Cogaz for ; Thu, 9 Feb 2017 10:54:51 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id DDFF95FAC9 for ; Thu, 9 Feb 2017 10:54:50 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B41C5E04B5 for ; Thu, 9 Feb 2017 10:54:43 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 8CFBD21D68 for ; Thu, 9 Feb 2017 10:54:42 +0000 (UTC) Date: Thu, 9 Feb 2017 10:54:42 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@gearpump.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEARPUMP-268) Use java.time.Instant instead of Long for timestamps MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 09 Feb 2017 10:54:54 -0000 [ https://issues.apache.org/jira/browse/GEARPUMP-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859347#comment-15859347 ] ASF GitHub Bot commented on GEARPUMP-268: ----------------------------------------- Github user manuzhang commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/142#discussion_r100279994 --- Diff: examples/streaming/state/src/main/scala/org/apache/gearpump/streaming/examples/state/processor/CountProcessor.scala --- @@ -37,7 +37,7 @@ class CountProcessor(taskContext: TaskContext, conf: UserConfig) } override def processMessage(state: PersistentState[Int], message: Message): Unit = { - state.update(message.timestamp, 1) + state.update(message.timestamp.toEpochMilli, 1) --- End diff -- yes, but I propose to hide `timeInMillis` from users in the future. > Use java.time.Instant instead of Long for timestamps > ---------------------------------------------------- > > Key: GEARPUMP-268 > URL: https://issues.apache.org/jira/browse/GEARPUMP-268 > Project: Apache Gearpump > Issue Type: Improvement > Reporter: Manu Zhang > Assignee: Manu Zhang > -- This message was sent by Atlassian JIRA (v6.3.15#6346)