gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEARPUMP-286) Different WindowAndGroups could end up in one due to hashCode collision
Date Tue, 28 Feb 2017 01:55:51 GMT

    [ https://issues.apache.org/jira/browse/GEARPUMP-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887053#comment-15887053
] 

ASF GitHub Bot commented on GEARPUMP-286:
-----------------------------------------

Github user huafengw commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/164
  
    Build passed: https://travis-ci.org/manuzhang/incubator-gearpump/builds/206019494
    +1 


> Different WindowAndGroups could end up in one due to hashCode collision 
> ------------------------------------------------------------------------
>
>                 Key: GEARPUMP-286
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-286
>             Project: Apache Gearpump
>          Issue Type: Bug
>          Components: streaming
>    Affects Versions: 0.8.2
>            Reporter: Manu Zhang
>            Assignee: Manu Zhang
>
> Currently, we use a {{TreeMap}} to store and sort {{WindowAndGroup}}, which requires
{{WindowAndGroup}} to be {{Comparable}}. However, {{Group}} is not and not supposed to be
so I hacked with its {{hashCode}} for comparison. That is wrong since two {{Group}} could
have identical {{hashCode}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message