gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEARPUMP-286) Different WindowAndGroups could end up in one due to hashCode collision
Date Tue, 28 Feb 2017 01:02:45 GMT

    [ https://issues.apache.org/jira/browse/GEARPUMP-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886966#comment-15886966
] 

ASF GitHub Bot commented on GEARPUMP-286:
-----------------------------------------

GitHub user manuzhang opened a pull request:

    https://github.com/apache/incubator-gearpump/pull/164

    [GEARPUMP-286] Fix window and group implementation in DefaultWindowRu…

    …nner
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the commit message is formatted like:
       `[GEARPUMP-<Jira issue #>] Meaningful description of pull request` 
     - [ ] Make sure tests pass via `sbt clean test`.
     - [ ] Make sure old documentation affected by the pull request has been updated and new
documentation added for new functionality. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manuzhang/incubator-gearpump GEARPUMP-286

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-gearpump/pull/164.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #164
    
----

----


> Different WindowAndGroups could end up in one due to hashCode collision 
> ------------------------------------------------------------------------
>
>                 Key: GEARPUMP-286
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-286
>             Project: Apache Gearpump
>          Issue Type: Bug
>          Components: streaming
>    Affects Versions: 0.8.2
>            Reporter: Manu Zhang
>            Assignee: Manu Zhang
>
> Currently, we use a {{TreeMap}} to store and sort {{WindowAndGroup}}, which requires
{{WindowAndGroup}} to be {{Comparable}}. However, {{Group}} is not and not supposed to be
so I hacked with its {{hashCode}} for comparison. That is wrong since two {{Group}} could
have identical {{hashCode}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message