gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEARPUMP-286) Different WindowAndGroups could end up in one due to hashCode collision
Date Tue, 28 Feb 2017 01:02:45 GMT


ASF GitHub Bot commented on GEARPUMP-286:

GitHub user manuzhang opened a pull request:

    [GEARPUMP-286] Fix window and group implementation in DefaultWindowRu…

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the commit message is formatted like:
       `[GEARPUMP-<Jira issue #>] Meaningful description of pull request` 
     - [ ] Make sure tests pass via `sbt clean test`.
     - [ ] Make sure old documentation affected by the pull request has been updated and new
documentation added for new functionality. 

You can merge this pull request into a Git repository by running:

    $ git pull GEARPUMP-286

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #164


> Different WindowAndGroups could end up in one due to hashCode collision 
> ------------------------------------------------------------------------
>                 Key: GEARPUMP-286
>                 URL:
>             Project: Apache Gearpump
>          Issue Type: Bug
>          Components: streaming
>    Affects Versions: 0.8.2
>            Reporter: Manu Zhang
>            Assignee: Manu Zhang
> Currently, we use a {{TreeMap}} to store and sort {{WindowAndGroup}}, which requires
{{WindowAndGroup}} to be {{Comparable}}. However, {{Group}} is not and not supposed to be
so I hacked with its {{hashCode}} for comparison. That is wrong since two {{Group}} could
have identical {{hashCode}}.

This message was sent by Atlassian JIRA

View raw message