gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEARPUMP-278) Default value skipped for START_CLOCK on ClockService
Date Tue, 21 Feb 2017 02:29:44 GMT

    [ https://issues.apache.org/jira/browse/GEARPUMP-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875252#comment-15875252
] 

ASF GitHub Bot commented on GEARPUMP-278:
-----------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/154
  
    # [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/154?src=pr&el=h1)
Report
    > Merging [#154](https://codecov.io/gh/apache/incubator-gearpump/pull/154?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-gearpump/commit/a996d397f7ed3cbcda934abafd67126607bb1eb7?src=pr&el=desc)
will **decrease** coverage by `-0.17%`.
    > The diff coverage is `100%`.
    
    
    
    ```diff
    @@            Coverage Diff             @@
    ##           master     #154      +/-   ##
    ==========================================
    - Coverage   71.75%   71.58%   -0.17%     
    ==========================================
      Files         191      191              
      Lines        6068     6068              
      Branches      522      526       +4     
    ==========================================
    - Hits         4354     4344      -10     
    - Misses       1714     1724      +10
    ```
    
    
    ------
    
    [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/154?src=pr&el=continue).
    > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
    > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
    > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/154?src=pr&el=footer).
Last update [a996d39...ee6e119](https://codecov.io/gh/apache/incubator-gearpump/compare/a996d397f7ed3cbcda934abafd67126607bb1eb7...ee6e11933c89d7aa76db7f3881029a08e9d609e7?el=footer&src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


> Default value skipped for START_CLOCK on ClockService
> -----------------------------------------------------
>
>                 Key: GEARPUMP-278
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-278
>             Project: Apache Gearpump
>          Issue Type: Bug
>    Affects Versions: 0.8.2
>            Reporter: Manu Zhang
>            Assignee: Manu Zhang
>
> The cause is when we get {{START_CLOCK}} from {{AppDataStore}}, it is converted to {{TimeStamp}}
or {{Long}}. If we haven't stored a previous value, then {{null}} is expected. That's why
we do {{Option(clock).getOrElse(0L)}}. In fact, {{0}} is returned when {{null}} is converted
to {{Long}}, which makes the default value useless.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message