gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEARPUMP-268) Use java.time.Instant instead of Long for timestamps
Date Thu, 09 Feb 2017 08:59:42 GMT

    [ https://issues.apache.org/jira/browse/GEARPUMP-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859227#comment-15859227
] 

ASF GitHub Bot commented on GEARPUMP-268:
-----------------------------------------

Github user huafengw commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/142#discussion_r100256683
  
    --- Diff: examples/streaming/state/src/main/scala/org/apache/gearpump/streaming/examples/state/processor/CountProcessor.scala
---
    @@ -37,7 +37,7 @@ class CountProcessor(taskContext: TaskContext, conf: UserConfig)
       }
     
       override def processMessage(state: PersistentState[Int], message: Message): Unit =
{
    -    state.update(message.timestamp, 1)
    +    state.update(message.timestamp.toEpochMilli, 1)
    --- End diff --
    
     message.timestamp.toEpochMilli == message.timeInMillis


> Use java.time.Instant instead of Long for timestamps
> ----------------------------------------------------
>
>                 Key: GEARPUMP-268
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-268
>             Project: Apache Gearpump
>          Issue Type: Improvement
>            Reporter: Manu Zhang
>            Assignee: Manu Zhang
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message