gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEARPUMP-103) Support finite stream, add stream-completion capability
Date Fri, 10 Feb 2017 01:24:42 GMT

    [ https://issues.apache.org/jira/browse/GEARPUMP-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15860507#comment-15860507
] 

ASF GitHub Bot commented on GEARPUMP-103:
-----------------------------------------

Github user huafengw commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/143#discussion_r100454422
  
    --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/task/TaskActor.scala
---
    @@ -247,7 +247,11 @@ class TaskActor(
             updateUpstreamMinClock(instant.toEpochMilli)
             minClockReported = false
           }
    -      receiveMessage(watermark.toMessage, sender)
    +
    +      // Instant.MAX marks the end of input stream
    +      if (instant.isBefore(Instant.MAX)) {
    +        receiveMessage(watermark.toMessage, sender)
    +      }
    --- End diff --
    
    Why the Task could not handle Instant.Max?


> Support finite stream, add stream-completion capability
> -------------------------------------------------------
>
>                 Key: GEARPUMP-103
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-103
>             Project: Apache Gearpump
>          Issue Type: New Feature
>          Components: streaming
>            Reporter: Manu Zhang
>            Assignee: Manu Zhang
>            Priority: Minor
>
> imported from [https://github.com/gearpump/gearpump/issues/1230] on behalf of [~clockfly],

> Whether we need to support finite stream that we allow a stream to complete?
> It may be useful if we want to handle some short living tasks.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message