gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From huafengw <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #143: [GEARPUMP-103] Support finite stream
Date Fri, 10 Feb 2017 01:24:28 GMT
Github user huafengw commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/143#discussion_r100454422
  
    --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/task/TaskActor.scala
---
    @@ -247,7 +247,11 @@ class TaskActor(
             updateUpstreamMinClock(instant.toEpochMilli)
             minClockReported = false
           }
    -      receiveMessage(watermark.toMessage, sender)
    +
    +      // Instant.MAX marks the end of input stream
    +      if (instant.isBefore(Instant.MAX)) {
    +        receiveMessage(watermark.toMessage, sender)
    +      }
    --- End diff --
    
    Why the Task could not handle Instant.Max?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message