gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manuzhang <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #142: [GEARPUMP-268] Accept java.time.Instan...
Date Thu, 09 Feb 2017 10:54:12 GMT
Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/142#discussion_r100279994
  
    --- Diff: examples/streaming/state/src/main/scala/org/apache/gearpump/streaming/examples/state/processor/CountProcessor.scala
---
    @@ -37,7 +37,7 @@ class CountProcessor(taskContext: TaskContext, conf: UserConfig)
       }
     
       override def processMessage(state: PersistentState[Int], message: Message): Unit =
{
    -    state.update(message.timestamp, 1)
    +    state.update(message.timestamp.toEpochMilli, 1)
    --- End diff --
    
    yes, but I propose to hide `timeInMillis` from users in the future. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message