gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manuzhang <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #140: [GEARPUMP-23] Add SessionWindows
Date Tue, 07 Feb 2017 12:48:43 GMT
Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/140#discussion_r99814058
  
    --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/api/WindowFunction.scala
---
    @@ -33,11 +33,19 @@ object WindowFunction {
     }
     
     trait WindowFunction[T] {
    +
       def apply(context: WindowFunction.Context[T]): Array[Window]
    +
    +  def isNonMerging: Boolean
    +}
    +
    +abstract class NonMergingWindowFunction[T] extends WindowFunction[T] {
    +
    +  override def isNonMerging: Boolean = true
    --- End diff --
    
    users are free to extend `WindowFunction`, which can not be matched 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message