Mailing-List: contact dev-help@gearpump.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@gearpump.incubator.apache.org
From: manuzhang <git@git.apache.org>
To: dev@gearpump.incubator.apache.org
Reply-To: dev@gearpump.incubator.apache.org
References: <git-pr-134-incubator-gearpump@git.apache.org>
In-Reply-To: <git-pr-134-incubator-gearpump@git.apache.org>
Subject: [GitHub] incubator-gearpump pull request #134: [GEARPUMP-265] remove AppMasterRuntime...
Content-Type: text/plain
Message-Id: <20170122083859.7D350DFCA1@git1-us-west.apache.org>
Date: Sun, 22 Jan 2017 08:38:59 +0000 (UTC)
archived-at: Sun, 22 Jan 2017 19:16:08 -0000

Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/134#discussion_r97216688
  
    --- Diff: core/src/main/scala/org/apache/gearpump/cluster/appmaster/ApplicationMetaData.scala ---
    @@ -19,18 +19,20 @@
     package org.apache.gearpump.cluster.appmaster
     
     import org.apache.gearpump.cluster.{AppDescription, AppJar}
    +import akka.routing.MurmurHash._
     
     /**
    - * This state for single application, it is be distributed across the masters.
    + * The meta data of an application, which stores the crucial infomation of how to launch
    + * the application, like the application jar file location. This data is distributed
    + * across the masters.
      */
    -case class ApplicationState(
    -    appId: Int, appName: String, attemptId: Int, app: AppDescription, jar: Option[AppJar],
    -    username: String, state: Any) extends Serializable {
    +case class ApplicationMetaData(appId: Int, attemptId: Int, app: AppDescription,
    +    jar: Option[AppJar], username: String) extends Serializable {
     
       override def equals(other: Any): Boolean = {
    --- End diff --
    
    why is `override` required ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---