Mailing-List: contact dev-help@gearpump.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@gearpump.incubator.apache.org
From: manuzhang <git@git.apache.org>
To: dev@gearpump.incubator.apache.org
Reply-To: dev@gearpump.incubator.apache.org
References: <git-pr-133-incubator-gearpump@git.apache.org>
In-Reply-To: <git-pr-133-incubator-gearpump@git.apache.org>
Subject: [GitHub] incubator-gearpump pull request #133: [GEARPUMP-252] return meaningful resul...
Content-Type: text/plain
Message-Id: <20170118020540.7E5BAE964D@git1-us-west.apache.org>
Date: Wed, 18 Jan 2017 02:05:40 +0000 (UTC)
archived-at: Wed, 18 Jan 2017 05:16:37 -0000

Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/133#discussion_r96554483
  
    --- Diff: core/src/main/scala/org/apache/gearpump/cluster/client/RunningApplication.scala ---
    @@ -0,0 +1,60 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *      http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.gearpump.cluster.client
    +
    +import akka.pattern.ask
    +import akka.actor.ActorRef
    +import akka.util.Timeout
    +import org.apache.gearpump.cluster.ClientToMaster.{ResolveAppId, ShutdownApplication}
    +import org.apache.gearpump.cluster.MasterToClient.{ResolveAppIdResult, ShutdownApplicationResult}
    +import org.apache.gearpump.util.ActorUtil
    +
    +import scala.concurrent.Future
    +import scala.util.{Failure, Success}
    +
    +class RunningApplication(val appId: Int, master: ActorRef, timeout: Timeout) {
    +  import scala.concurrent.ExecutionContext.Implicits.global
    +  lazy val appMaster: ActorRef = resolveAppMaster(appId)
    +
    +  def shutDown(): Unit = {
    +    val result = ActorUtil.askActor[ShutdownApplicationResult](master,
    +      ShutdownApplication(appId), timeout)
    +    result.appId match {
    +      case Success(_) =>
    +      case Failure(ex) => throw ex
    +    }
    +  }
    +
    +  def askMaster[T](msg: Any): Future[T] = {
    +    appMaster.ask(msg)(timeout).asInstanceOf[Future[T]]
    +  }
    +
    +//  Todo
    --- End diff --
    
    I'm afraid the intention for these lines could be forgotten after a while so maybe better just remove them for now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---