gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEARPUMP-265) remove AppMasterRuntimeInfo from AppMasterContext
Date Mon, 23 Jan 2017 04:57:27 GMT

    [ https://issues.apache.org/jira/browse/GEARPUMP-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833905#comment-15833905
] 

ASF GitHub Bot commented on GEARPUMP-265:
-----------------------------------------

Github user huafengw commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/134#discussion_r97253035
  
    --- Diff: core/src/main/scala/org/apache/gearpump/cluster/AppDescription.scala ---
    @@ -142,4 +138,25 @@ case class ExecutorContext(
     case class ExecutorJVMConfig(
         classPath: Array[String], jvmArguments: Array[String], mainClass: String,
         arguments: Array[String], jar: Option[AppJar], username: String,
    -    executorAkkaConfig: Config = ConfigFactory.empty())
    \ No newline at end of file
    +    executorAkkaConfig: Config = ConfigFactory.empty())
    +
    +sealed abstract class ApplicationStatus(val status: String, val isTerminal: Boolean)
    --- End diff --
    
    good idea


> remove AppMasterRuntimeInfo from AppMasterContext
> -------------------------------------------------
>
>                 Key: GEARPUMP-265
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-265
>             Project: Apache Gearpump
>          Issue Type: Sub-task
>    Affects Versions: 0.8.2
>            Reporter: Huafeng Wang
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message