gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEARPUMP-265) remove AppMasterRuntimeInfo from AppMasterContext
Date Mon, 23 Jan 2017 02:33:26 GMT

    [ https://issues.apache.org/jira/browse/GEARPUMP-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833817#comment-15833817
] 

ASF GitHub Bot commented on GEARPUMP-265:
-----------------------------------------

Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/134#discussion_r97245165
  
    --- Diff: core/src/main/scala/org/apache/gearpump/cluster/client/RunningApplication.scala
---
    @@ -40,6 +44,12 @@ class RunningApplication(val appId: Int, master: ActorRef, timeout:
Timeout) {
         }
       }
     
    +  def waitUnilFinish(): ApplicationResult = {
    +    val delegator = system.actorOf(Props(new AppResultListener(appId, master)))
    +    Await.result(delegator.ask(WaitUntilFinish)(INF_TIMEOUT).asInstanceOf
    --- End diff --
    
    What are the effects of the two Timeout values here ? 


> remove AppMasterRuntimeInfo from AppMasterContext
> -------------------------------------------------
>
>                 Key: GEARPUMP-265
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-265
>             Project: Apache Gearpump
>          Issue Type: Sub-task
>    Affects Versions: 0.8.2
>            Reporter: Huafeng Wang
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message