gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEARPUMP-265) remove AppMasterRuntimeInfo from AppMasterContext
Date Mon, 23 Jan 2017 02:22:26 GMT

    [ https://issues.apache.org/jira/browse/GEARPUMP-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833813#comment-15833813
] 

ASF GitHub Bot commented on GEARPUMP-265:
-----------------------------------------

Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/134#discussion_r97244536
  
    --- Diff: core/src/main/scala/org/apache/gearpump/cluster/ClusterMessage.scala ---
    @@ -155,9 +158,13 @@ object MasterToClient {
     
       /** Return the last error of this streaming application job */
       case class LastFailure(time: TimeStamp, error: String)
    -}
     
    -trait AppMasterRegisterData
    +  sealed trait ApplicationResult
    +
    +  case class ApplicationFinished(appId: Int) extends ApplicationResult
    --- End diff --
    
    What does `Finished` mean ? Do you want to say `Succeeded` ?


> remove AppMasterRuntimeInfo from AppMasterContext
> -------------------------------------------------
>
>                 Key: GEARPUMP-265
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-265
>             Project: Apache Gearpump
>          Issue Type: Sub-task
>    Affects Versions: 0.8.2
>            Reporter: Huafeng Wang
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message