gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEARPUMP-265) remove AppMasterRuntimeInfo from AppMasterContext
Date Sun, 22 Jan 2017 08:37:27 GMT

    [ https://issues.apache.org/jira/browse/GEARPUMP-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833364#comment-15833364
] 

ASF GitHub Bot commented on GEARPUMP-265:
-----------------------------------------

Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/134#discussion_r97216646
  
    --- Diff: core/src/main/scala/org/apache/gearpump/cluster/appmaster/ApplicationMetaData.scala
---
    @@ -19,18 +19,20 @@
     package org.apache.gearpump.cluster.appmaster
     
     import org.apache.gearpump.cluster.{AppDescription, AppJar}
    +import akka.routing.MurmurHash._
     
     /**
    - * This state for single application, it is be distributed across the masters.
    + * The meta data of an application, which stores the crucial infomation of how to launch
    + * the application, like the application jar file location. This data is distributed
    + * across the masters.
      */
    -case class ApplicationState(
    -    appId: Int, appName: String, attemptId: Int, app: AppDescription, jar: Option[AppJar],
    -    username: String, state: Any) extends Serializable {
    +case class ApplicationMetaData(appId: Int, attemptId: Int, app: AppDescription,
    --- End diff --
    
    better name `app` to `appDesc` or `appDescription`


> remove AppMasterRuntimeInfo from AppMasterContext
> -------------------------------------------------
>
>                 Key: GEARPUMP-265
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-265
>             Project: Apache Gearpump
>          Issue Type: Sub-task
>    Affects Versions: 0.8.2
>            Reporter: Huafeng Wang
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message