gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEARPUMP-252) return application status to client
Date Wed, 18 Jan 2017 02:28:27 GMT

    [ https://issues.apache.org/jira/browse/GEARPUMP-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15827331#comment-15827331
] 

ASF GitHub Bot commented on GEARPUMP-252:
-----------------------------------------

Github user huafengw commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/133#discussion_r96557102
  
    --- Diff: core/src/main/scala/org/apache/gearpump/cluster/client/ClientContext.scala ---
    @@ -53,20 +55,21 @@ class ClientContext(config: Config, sys: ActorSystem, _master: ActorRef)
{
       }
     
       private val LOG: Logger = LogUtil.getLogger(getClass)
    -  private implicit val timeout = Timeout(5, TimeUnit.SECONDS)
    -
       implicit val system = Option(sys).getOrElse(ActorSystem(s"client${Util.randInt()}",
config))
       LOG.info(s"Starting system ${system.name}")
    -  val shouldCleanupSystem = Option(sys).isEmpty
    -
    +  private val shouldCleanupSystem = Option(sys).isEmpty
    --- End diff --
    
    The `system` won't be empty but `sys` can still be empty. `sys` not being empty means
user has provided a ActorSystem so clientcontext should clean up user's actor system when
being closed.


> return application status to client
> -----------------------------------
>
>                 Key: GEARPUMP-252
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-252
>             Project: Apache Gearpump
>          Issue Type: Improvement
>    Affects Versions: 0.8.2
>            Reporter: Manu Zhang
>            Assignee: Huafeng Wang
>
> Currently, client exits after submitting applications and has no idea of the application
status. It will be valuable to return such information to client. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message