gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manuzhang <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #134: [GEARPUMP-252] return application stat...
Date Mon, 23 Jan 2017 08:52:12 GMT
Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/134#discussion_r97273193
  
    --- Diff: core/src/main/scala/org/apache/gearpump/cluster/client/RunningApplication.scala
---
    @@ -18,17 +18,21 @@
     package org.apache.gearpump.cluster.client
     
     import akka.pattern.ask
    -import akka.actor.ActorRef
    +import akka.actor.{Actor, ActorRef, ActorSystem, Props}
     import akka.util.Timeout
    -import org.apache.gearpump.cluster.ClientToMaster.{ResolveAppId, ShutdownApplication}
    -import org.apache.gearpump.cluster.MasterToClient.{ResolveAppIdResult, ShutdownApplicationResult}
    +import org.apache.gearpump.cluster.ClientToMaster.{RegisterAppResultListener, ResolveAppId,
ShutdownApplication}
    +import org.apache.gearpump.cluster.MasterToClient._
    +import org.apache.gearpump.cluster.client.RunningApplication.{AppResultListener, WaitUntilFinish}
     import org.apache.gearpump.util.ActorUtil
    +import org.apache.gearpump.cluster.client.RunningApplication._
     
    +import scala.concurrent.duration._
     import scala.concurrent.Future
     import scala.util.{Failure, Success}
     import scala.concurrent.ExecutionContext.Implicits.global
     
    -class RunningApplication(val appId: Int, master: ActorRef, timeout: Timeout) {
    +class RunningApplication(val appId: Int, master: ActorRef, timeout: Timeout,
    --- End diff --
    
    I think we need a user interface here. `RunningApplication` could be the default implementation.
Plus, please add guide on how to use the interface. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message