gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manuzhang <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #134: [GEARPUMP-265] remove AppMasterRuntime...
Date Mon, 23 Jan 2017 02:44:48 GMT
Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/134#discussion_r97245819
  
    --- Diff: core/src/main/scala/org/apache/gearpump/cluster/client/RunningApplication.scala
---
    @@ -50,3 +60,23 @@ class RunningApplication(val appId: Int, master: ActorRef, timeout:
Timeout) {
       }
     }
     
    +object RunningApplication {
    +  // This magic number is derived from Akka's configuration, which is the maximum delay
    +  private val INF_TIMEOUT = new Timeout(2147482 seconds)
    +
    +  private case object WaitUntilFinish
    +
    +  private class AppResultListener(appId: Int, master: ActorRef) extends Actor {
    --- End diff --
    
    I think you reimplemented the ask pattern.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message